Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Warn against using progress for more than one state at a time #22

Closed
wants to merge 1 commit into from
Closed

docs: Warn against using progress for more than one state at a time #22

wants to merge 1 commit into from

Conversation

johanhelsing
Copy link

@johanhelsing johanhelsing commented Feb 26, 2023 •
edited
Loading

We should obviously revert this when #20 is fixed, but in the meantime, don't encourage users to do this.

@johanhelsing
docs: Warn against using progress for more than one state at a time
3768041 
We should obviously revert this when IyesGames#23 is fixed, but in the meantime,
don't encourage users to do this.
@inodentry
Copy link
Collaborator

Good idea, but I thought I could word it better. Closing your PR in favor of my commit 12e7058.

@inodentry inodentry closed this Mar 9, 2023
@johanhelsing
Copy link
Author

after 12e7058 the crate docs have a warning, but the readme still recommends using it for cooldowns etc. without the warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johanhelsing @inodentry